feat: Ledger device support #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamspofford-dfinity
force-pushed
the
spofford/ledger
branch
from
e6e7523
to
310b20f
Compare
adamspofford-dfinity
force-pushed
the
spofford/ledger
branch
from
ea09bbc
to
db7f7b1
Compare
ericswanson-dfinity
requested changes
Jun 12, 2023
ericswanson-dfinity
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ledger device support to Quill. The
--ledgerflag authenticates any commands, prompting the user to confirm on the device.Automated testing has proved too difficult to set up out of the box and will probably have to be manually implemented in a future PR; I have tested it locally on Mac and Windows. (
nns-dappdoesn't seem to have figured it out either.)The version of the ICP app on Ledger Live lags behind Zondax's main branch by several features, especially neuron management functionality. Several tests have been commented out but should be uncommented when the app updates next.
LedgerIdentityinvolves an unfortunate amount of global state and should probably not be released as a library any time soon.