Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require --ticket-creation-time in sns pay #159

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: require --ticket-creation-time in sns pay #159

merged 2 commits into from
Feb 14, 2023

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Feb 13, 2023 •
edited
Loading

Checklist:

  • I have made corresponding changes to the documentation in src/docs.

@lwshang lwshang marked this pull request as ready for review February 13, 2023 21:09
@lwshang lwshang assigned DanielThurau and unassigned DanielThurau Feb 13, 2023
DanielThurau
DanielThurau approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@DanielThurau DanielThurau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwshang lwshang merged commit 81272c9 into master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielThurau DanielThurau DanielThurau approved these changes

@MarioDfinity MarioDfinity MarioDfinity approved these changes

@dfx-json dfx-json dfx-json approved these changes

@adamspofford-dfinity adamspofford-dfinity Awaiting requested review from adamspofford-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwshang @DanielThurau @MarioDfinity @dfx-json