Skip to content

Conversation

@AntonioVentilii
Copy link
Collaborator

Motivation

Given recent reproducibilities issues with bumping Tailwind v4 (see one of the fixes here), we include the CI that checks the frontend reproducibility in each PR, and on main.

Furthermore, once this PR is merged, we will add the check among the compulsory ones to be able to merge any PR.

@AntonioVentilii AntonioVentilii force-pushed the feat(ci)/run-frontend-reproducibility-in-each-PR branch from 74d39b9 to 86c0493 Compare February 18, 2025 23:57
@peterpeterparker
Copy link
Member

I would run it on package-lock change.

@AntonioVentilii
Copy link
Collaborator Author

AntonioVentilii commented Feb 19, 2025

@peterpeterparker I changed the pull_request parameter to be only for that. But what do you think of having a permanent check on main? Too redundant?

@peterpeterparker
Copy link
Member

Not sure it's redundant, just asking my self about workload. The script performs 10 npm ci && npm run build in a row.

@AntonioVentilii
Copy link
Collaborator Author

@peterpeterparker then I will remove the trigger by main for now (we didn't have it before anyway), and revisit in case there we find a case. So, just on pull_request on package-lock for now

@AntonioVentilii AntonioVentilii marked this pull request as ready for review February 24, 2025 21:59
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner February 24, 2025 21:59
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii AntonioVentilii merged commit 734b437 into main Feb 28, 2025
22 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(ci)/run-frontend-reproducibility-in-each-PR branch February 28, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants