fix: system-tests: ensure no blocking code is used in async contexts #8287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blind-oracle
approved these changes
Jan 9, 2026
frankdavid
reviewed
Jan 9, 2026
nmattia
approved these changes
Jan 9, 2026
Contributor
nmattia
left a comment
nmattia
left a comment
There was a problem hiding this comment.
Mostly a rubber stamp; approved modulo the unnecessary async { ...await } blocks
mraszyk
approved these changes
Jan 9, 2026
Contributor
mraszyk
left a comment
mraszyk
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
eichhorl
approved these changes
Jan 9, 2026
frankdavid
approved these changes
Jan 9, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maksymar
pushed a commit
that referenced
this pull request
Jan 13, 2026
What? === Add support for Claude Code for developing dfinity/ic. Why? ==== We should use AI tools more for developing dfinity/ic to increase our productivity. I had some initial success: using this PR `claude` was able to produce #8287 with about 4 prompts and a bit of manual work. How? === ~* Install the `claude` CLI in the dev container. It's important to have `claude` run in the dev container such that it can easily call `cargo` and `bazel` without wrapping all those commands in `ci/container/container-run.sh` and such that the bazel server keeps running.~ This has been reverted because we'll first split up the CI from the dev-container and then add `claude` to the dev-container. * ~Install the Claude Code VS Code extension. For me the extension is not working correctly yet since I can't login for some reason. I need to debug this further with IT.~ This has also been reverted and we'll probably also do this later. * Add a `.claude/README.md` with some preliminary notes on how to use `claude`. * Add a preliminary `.claude/CLAUDE.md` instructing Claude how to build and test the ic repository. This document is submitted with every prompt. We expect it to be continuously tweaked by every team to optimise their prompting. Future Work === Add [hooks](https://code.claude.com/docs/en/hooks-guide) --- Consider moving some of the instructions from `.claude/CLAUDE.md` to hooks like `cargo fmt` and `cargo clippy` after modifying .rs files. This will keep the context as small as possible. Add dfinity/ic specific [Agent Skills](https://platform.claude.com/docs/en/agents-and-tools/agent-skills/overview). --- Examples: * How to query Apache Superset (or ideally the PostgreSQL DB directly via `psql`) for: the most flaky tests, the slowest tests on PRs, previous failed / flaky tests runs of a given test, failure rate of a given test over time, run time of a given test over time. * How to download a bazel test log from BuildBuddy. * How to debug system-tests. * How to download the IC node logs of a testnet / mainnet from ElasticSearch. * How to query Prometheus in testnets for relevant metrics. Interesting Reads === Apart from the [Claude Code Docs](https://code.claude.com/docs) the following are interesting Reads on how to optimize working with Claude Code: * https://medium.com/@joe.njenga/17-best-claude-code-workflows-that-separate-amateurs-from-pros-instantly-level-up-5075680d4c49 * https://x.com/i/status/2007179832300581177 --------- Co-authored-by: IDX GitHub Automation <> Co-authored-by: Nicolas Mattia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently after 70fb598 system-tests that used blocking code in an async context started failing with:
To fix this we make the
rs/tests/driver/src/driver/farm.rsmodule and its call-sites async.