Skip to content

feat(ICP_Ledger): add ICRC-10 to list of supported standards #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mducroux merged 5 commits into from
Jan 8, 2026
Merged

feat(ICP_Ledger): add ICRC-10 to list of supported standards #8264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d660d38
add ICRC-10 to list of supported standards of ICP ledger
mducroux Jan 8, 2026
ae228ad
Automatically fixing code for linting and formatting issues
Jan 8, 2026
152e873
Update lib.rs
mducroux Jan 8, 2026
c6f16ca
Update lib.rs
mducroux Jan 8, 2026
8e682c9
Merge branch 'master' into mducroux/DEFI-1674-add-icrc10-to-icp-ledge…
mducroux Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rs/ledger_suite/icp/ledger/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,10 @@ fn icrc1_supported_standards() -> Vec<StandardRecord> {
url: "https://github.com/dfinity/wg-identity-authentication/blob/main/topics/ICRC-21/icrc_21_consent_msg.md".to_string(),
}
);
standards.push(StandardRecord {
name: "ICRC-10".to_string(),
url: "https://github.com/dfinity/ICRC/blob/main/ICRCs/ICRC-10/ICRC-10.md".to_string(),
});

standards
}
Expand Down
2 changes: 1 addition & 1 deletion rs/ledger_suite/icp/ledger/tests/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,7 @@ fn test_feature_flags() {
standards.push(standard.name);
}
standards.sort();
assert_eq!(standards, vec!["ICRC-1", "ICRC-2", "ICRC-21"]);
assert_eq!(standards, vec!["ICRC-1", "ICRC-10", "ICRC-2", "ICRC-21"]);

let block_index =
send_approval(&env, canister_id, from.0, &approve_args).expect("approval failed");
Expand Down
6 changes: 3 additions & 3 deletions rs/ledger_suite/tests/sm-tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ where
standards.push(standard.name);
}
standards.sort();
assert_eq!(standards, vec!["ICRC-1", "ICRC-2", "ICRC-21"]);
assert_eq!(standards, vec!["ICRC-1", "ICRC-10", "ICRC-2", "ICRC-21"]);
}
pub fn test_metadata<T>(ledger_wasm: Vec<u8>, encode_init_args: fn(InitArgs) -> T)
where
Expand Down Expand Up @@ -3882,7 +3882,7 @@ pub fn expect_icrc2_disabled(
"ICRC-2 features are not enabled on the ledger.",
);
let standards = supported_standards(env, canister_id);
assert_eq!(standards.len(), 2);
assert_eq!(standards.len(), 3);
assert_eq!(standards[0].name, "ICRC-1");
}

Expand Down Expand Up @@ -3955,7 +3955,7 @@ where
standards.push(standard.name);
}
standards.sort();
assert_eq!(standards, vec!["ICRC-1", "ICRC-2", "ICRC-21"]);
assert_eq!(standards, vec!["ICRC-1", "ICRC-10", "ICRC-2", "ICRC-21"]);

let block_index =
send_approval(&env, canister_id, from.0, &approve_args).expect("approval failed");
Expand Down
Loading