chore: CON-1315 Switch proto conversions to *_id_try_from_option
#8250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places in the repository use the following structure to convert an optional ID protobuf type:
This is confusing since it abuses the fact that
TryFrom<T>is implemented for allT. Specifically, the call totry_from_option_fielddoesn't actually do any conversion, it simply extracts the value out of the option, or returns an error if no value exists.This PR switches all of these occurences to their
*_id_try_from_optionequivalent, similar to what was done in 1292045 for theNodeId:For
UserId, such a function had to be introduced first. In the process of doing that I removed an unnecessary.unwrap()and return an error instead.