refactor(ICRC_Rosetta): DEFI-2491: Use StorageError enum for storage operations #8236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.Bazel.json.lock # rs/rosetta-api/icrc1/src/common/storage/storage_client.rs
# Conflicts: # Cargo.Bazel.json.lock
# Conflicts: # Cargo.Bazel.json.lock
…hias/DEFI-2452-icrc-rosetta-tokio-rusqlite-storageerror-enum
mbjorkqvist
changed the base branch from
master
to
mathias/DEFI-2452-icrc-rosetta-tokio-rusqlite
…hias/DEFI-2452-icrc-rosetta-tokio-rusqlite-storageerror-enum # Conflicts: # rs/rosetta-api/icrc1/src/common/storage/storage_client.rs
Base automatically changed from
mathias/DEFI-2452-icrc-rosetta-tokio-rusqlite
to
master
January 9, 2026 19:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
StorageErrorenum for storage operation errors. The wrapper aroundanyhow::Errorin this commit in the parent PR seems to be an improvement on the initial implementation, but it has a code smell -anyhow::Errorintentionally doesn't implementstd::error::Error. This PR proposes to use aStorageErrorenumeration with explicit variants for database errors (rusqlite::Error) and a couple of other types. For more complex internal errors, anInternalvariant is used to wrap existinganyhow::Errors - these currently mainly come fromupdate_account_balances. Ideally, we wouldn't have theInternalvariant wrappinganyhow::Erroreither - we could work on removing that in subsequent commits in this PR.