refactor: Add new generate-guestos-vm-config feature to ic-os config tool which replaces generate-guestos-config.sh #5264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new Rust-based implementation for generating bootstrap configuration images
…p-config # Conflicts: # rs/tests/driver/src/driver/bootstrap.rs
In addition, calculate IP address from the passed config instead of taking it as a separate argument.
…david/generate-vm-config
…david/generate-vm-config
…-vm-config # Conflicts: # Cargo.Bazel.json.lock
…oducility-of-generate-vm-config' into frankdavid/generate-vm-config # Conflicts: # rs/ic_os/config/BUILD.bazel
nmattia
reviewed
May 26, 2025
…-vm-config # Conflicts: # Cargo.Bazel.Fuzzing.json.lock # Cargo.Bazel.json.lock
Comment on lines
+67
to
+70
| bail!( | ||
| "GuestOS configuration file already exists: {}", | ||
| args.output.display() | ||
| ); |
Contributor
There was a problem hiding this comment.
If the configuration file already exists, will the generate-guestos-config service fail here? Don't we just want to early retun, not fail?
I supposed this can easily be tested just by rebooting HostOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few motivators of the new implementation:
I manually verified that the behavior of the new tool is the same as the old bash script. The only difference is that we create the guestos config in a temp file instead of
/boot/config/config-guestos.json. Since this file is only used to create the bootstrap config image, it's not necessary to store it on the config partition. In a later PR, we can completely remove the temporary file and just pass around a Rust struct.