Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rust version to 1.81 #1645

Merged
merged 16 commits into from
Sep 26, 2024
Merged

Conversation

DSharifi
Copy link
Member

@DSharifi DSharifi commented Sep 24, 2024

This PR upgrades the rust version of the repo to 1.81

All changes made are to satisfy the new clippy lints, or warnings from the compiler of patterns that will turn into hard errors in the 2024 edition of rust.

@github-actions github-actions bot added the chore label Sep 24, 2024
…e3bb2f48df576bc2c23067eefce84b

Image tag: 0bae86526532874d50992514f46cba23aac279315fd3e8d6726310e997751101
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/11012732589

New container image: sha256:115daa5ad5149182bb0416cbe5730f305be3bb2f48df576bc2c23067eefce84b
New container tag: 0bae86526532874d50992514f46cba23aac279315fd3e8d6726310e997751101

@DSharifi DSharifi marked this pull request as ready for review September 24, 2024 20:55
@DSharifi DSharifi requested review from a team as code owners September 24, 2024 20:55
Copy link
Contributor

@alin-at-dfinity alin-at-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

rs/boundary_node/prober/src/main.rs Show resolved Hide resolved
Copy link
Member

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @DSharifi!

Copy link
Contributor

@kpop-dfinity kpop-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Copy link
Contributor

@adambratschikaye adambratschikaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DSharifi DSharifi enabled auto-merge September 25, 2024 08:43
@DSharifi DSharifi added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@DSharifi DSharifi added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@DSharifi DSharifi added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@DSharifi DSharifi enabled auto-merge September 25, 2024 10:28
@DSharifi DSharifi added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 25, 2024
@DSharifi DSharifi enabled auto-merge September 26, 2024 07:18
@DSharifi DSharifi added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit d66fdcb Sep 26, 2024
28 checks passed
@DSharifi DSharifi deleted the dsharifi/bump-rust-version-1.81 branch September 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.