Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #152

Merged
merged 10 commits into from
Mar 10, 2023
Merged

Update README #152

merged 10 commits into from
Mar 10, 2023

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Mar 10, 2023 •
edited
Loading

This MR makes the following updates to the README:

  • update links to Interface Spec
  • drop ghcid instructions (ghcid might not work any longer)
  • drop cabal repl instructions (I could not reproduce them anymore)
  • using ic-ref with dfx
  • replace 0.0.0.0 by localhost
  • fix typos

@mraszyk mraszyk requested a review from a team as a code owner March 10, 2023 08:25
dsd-at-dfinity
dsd-at-dfinity approved these changes Mar 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nomeata
Copy link
Contributor

nomeata commented Mar 10, 2023

drop ghcid instructions (ghcid might not work any longer)
drop cabal repl instructions (I could not reproduce them anymore)

Too bad, I found that this quick roundtrip mode made working on this code base much easier. But yes, #141 made it certainly harder. Will work better once haskell/cabal#8238 is fully implemented.

nomeata
nomeata reviewed Mar 10, 2023
View reviewed changes
README.md Show resolved Hide resolved
mraszyk and others added 2 commits March 10, 2023 09:50
@mraszyk @dsd-at-dfinity
Update README.md
2409403 
Co-authored-by: dsd-at-dfinity <[email protected]>
@mraszyk @dsd-at-dfinity
Update README.md
f39c17f 
Co-authored-by: dsd-at-dfinity <[email protected]>
@mraszyk mraszyk merged commit ca6aca9 into master Mar 10, 2023
@mraszyk mraszyk deleted the mraszyk/readme branch March 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata left review comments

@dsd-at-dfinity dsd-at-dfinity dsd-at-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mraszyk @nomeata @dsd-at-dfinity