chore: separate metrics for consensus errors#520
Merged
Conversation
lpahlavi
changed the title
gregorydemay
approved these changes
Nov 13, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for adding this!
lpahlavi
deleted the
lpahlavi/defi-2461-separate-consensus-error-metrics
branch
Merged
lpahlavi
added a commit
that referenced
this pull request
Nov 17, 2025
## 🤖 New release * `evm_rpc`: 2.7.0 -> 2.7.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `evm_rpc` <blockquote> ## [2.7.1] - 2025-11-17 ### Changed - Add metrics label identifying requests made with supported providers ([#521](#521)) - Separate consensus errors from other HTTP outcall errors in metrics ([#520](#520)) [2.7.1]: evm_rpc-v2.7.0...evm_rpc-v2.7.1 </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(DEFI-2461) Currently, virtually all HTTP outcall errors are caused by lack of consensus between replicas, leading to misleading error statistics. This can occur frequently for calls that return fast-changing data (e.g.
eth_callon volatile contracts oreth_blockNumber).This change introduces a new metric,
evmrpc_err_no_consensus, to distinctly track consensus-related outcall errors, separating them from other, potentially more critical, error types.