Conversation
github-actions
bot
force-pushed
the
release-plz-2025-10-21T12-46-33Z
branch
from
cce3eb2 to
3c32ed9
Compare
gregorydemay
reviewed
Nov 3, 2025
evm_rpc_client/CHANGELOG.md
Outdated
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres |
Contributor
There was a problem hiding this comment.
I'm not sure why this was changed.
Contributor
There was a problem hiding this comment.
I think this was a sneaky edit from IntelliJ formatting. Reverted.
evm_rpc_client/CHANGELOG.md
Outdated
| - Add `.request_cost()` method to `RequestBuilder` to compute the cycles cost of a request via the new `CyclesCost` | ||
| query endpoints ([#509](https://github.com/dfinity/evm-rpc-canister/pull/509)) | ||
| - Add the option to configure a retry strategy in the EVM RPC client to e.g., try a request with increasingly many | ||
| cycles if it fails to to insufficient cycles ([#512](https://github.com/dfinity/evm-rpc-canister/pull/512)) |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| cycles if it fails to to insufficient cycles ([#512](https://github.com/dfinity/evm-rpc-canister/pull/512)) | |
| cycles if it fails due to insufficient cycles ([#512](https://github.com/dfinity/evm-rpc-canister/pull/512)) |
evm_rpc_client/Cargo.toml
Outdated
| [package] | ||
| name = "evm_rpc_client" | ||
| version = "0.1.0" | ||
| version = "0.1.1" |
Contributor
There was a problem hiding this comment.
Shouldn't that be
Suggested change
| version = "0.1.1" | |
| version = "0.2.0" |
|
|
||
| ## [0.2.0] - 2025-11-03 | ||
|
|
||
| ### Added |
Contributor
There was a problem hiding this comment.
nit: I would avoid hard-wraps but rather have one item per line in the file. WDYT?
Contributor
There was a problem hiding this comment.
Hm yes, I think this was also a sneaky edit from IntelliJ formatting. Done.
lpahlavi
reviewed
Nov 3, 2025
Contributor
lpahlavi
left a comment
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks for the review @gregorydemay! Your comments should have been all addressed!
evm_rpc_client/CHANGELOG.md
Outdated
| - Add `.request_cost()` method to `RequestBuilder` to compute the cycles cost of a request via the new `CyclesCost` | ||
| query endpoints ([#509](https://github.com/dfinity/evm-rpc-canister/pull/509)) | ||
| - Add the option to configure a retry strategy in the EVM RPC client to e.g., try a request with increasingly many | ||
| cycles if it fails to to insufficient cycles ([#512](https://github.com/dfinity/evm-rpc-canister/pull/512)) |
|
|
||
| ## [0.2.0] - 2025-11-03 | ||
|
|
||
| ### Added |
Contributor
There was a problem hiding this comment.
Hm yes, I think this was also a sneaky edit from IntelliJ formatting. Done.
evm_rpc_client/CHANGELOG.md
Outdated
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres |
Contributor
There was a problem hiding this comment.
I think this was a sneaky edit from IntelliJ formatting. Reverted.
gregorydemay
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
evm_rpc_client: 0.1.0 -> 0.2.0 (✓ API compatible changes)evm_rpc: 2.6.0 -> 2.7.0 (✓ API compatible changes)Changelog
evm_rpc_clientevm_rpcThis PR was generated with release-plz.