Skip to content

fix: move non-alloy conversion from behind alloy feature #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpahlavi merged 2 commits into from
Oct 10, 2025
Merged

fix: move non-alloy conversion from behind alloy feature #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a312a
Move non-alloy code from alloy module
lpahlavi Oct 9, 2025
25a1e1a
Unused import
lpahlavi Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions evm_rpc_types/src/request/alloy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{
AccessList, AccessListEntry, BlockTag, CallArgs, GetLogsArgs, Hex, Hex20, Hex32, HexByte,
Nat256, RpcError, TransactionRequest, ValidationError,
AccessList, AccessListEntry, BlockTag, CallArgs, Hex, Hex20, Hex32, HexByte, Nat256, RpcError,
TransactionRequest, ValidationError,
};
use alloy_primitives::TxKind;

Expand Down Expand Up @@ -33,17 +33,6 @@ impl TryFrom<BlockTag> for alloy_rpc_types::BlockNumberOrTag {
}
}

impl<T: IntoIterator<Item = S>, S: Into<Hex20>> From<T> for GetLogsArgs {
fn from(addresses: T) -> Self {
Self {
from_block: None,
to_block: None,
addresses: addresses.into_iter().map(Into::into).collect(),
topics: None,
}
}
}

impl TryFrom<alloy_rpc_types::TransactionRequest> for CallArgs {
type Error = RpcError;

Expand Down
11 changes: 11 additions & 0 deletions evm_rpc_types/src/request/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,17 @@ pub struct GetLogsArgs {
pub topics: Option<Vec<Vec<Hex32>>>,
}

impl<T: IntoIterator<Item = S>, S: Into<Hex20>> From<T> for GetLogsArgs {
fn from(addresses: T) -> Self {
Self {
from_block: None,
to_block: None,
addresses: addresses.into_iter().map(Into::into).collect(),
topics: None,
}
}
}

#[derive(Clone, Debug, PartialEq, Eq, CandidType, Deserialize)]
pub struct GetTransactionCountArgs {
pub address: Hex20,
Expand Down