test: client integration test infrastructure#448
Merged
Conversation
lpahlavi
changed the title
Co-authored-by: gregorydemay <112856886+gregorydemay@users.noreply.github.com>
lpahlavi
commented
Sep 2, 2025
Contributor
Author
|
Thanks a lot for the first round of reviews @gregorydemay! I believe this should be ready for round 2 🚀 |
gregorydemay
reviewed
Sep 3, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for all the improvements! Couple of minor comments regarding mocking but otherwise starting to look very good!
This reverts commit 7f2c6be.
lpahlavi
commented
Sep 3, 2025
Contributor
Author
There was a problem hiding this comment.
Thanks a lot @gregorydemay for your feedback! I think it's starting to look overall really pretty good!
gregorydemay
reviewed
Sep 4, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
I think the whole mock infrastructure is now really nice. A couple of minor comments but otherwise looks good! Thanks a lot for this effort!
lpahlavi
commented
Sep 4, 2025
Contributor
Author
lpahlavi
left a comment
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks a lot for all the reviews and feedback @gregorydemay! Very happy with the outcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(XC-412) Add a
PocketIcRuntimeimplementation and some basic integration tests for the client'seth_getLogsmethod added in #447.Follow-up PRs will include adding more methods to the client and the corresponding integration tests using the infrastructure added in this PR.