Skip to content

fix: missing optional dependency on serde for multi feature#47

Merged
lpahlavi merged 1 commit intomainfrom
lpahlavi/enable-serde-with-multi
Nov 17, 2025
Merged

fix: missing optional dependency on serde for multi feature#47
lpahlavi merged 1 commit intomainfrom
lpahlavi/enable-serde-with-multi

Conversation

@lpahlavi
Copy link
Contributor

The multi feature requires the serde optional dependency due to the use of serde::Serialize in canhttp/src/multi/reduce.rs, however this conditional dependency was missing in canhttp/Cargo.toml. This PR fixes this by enabling the serde dependency when the multi feature is enabled.

@lpahlavi lpahlavi marked this pull request as ready for review November 13, 2025 16:07
@lpahlavi lpahlavi requested a review from a team as a code owner November 13, 2025 16:07
@lpahlavi lpahlavi merged commit 8575221 into main Nov 17, 2025
9 checks passed
@lpahlavi lpahlavi deleted the lpahlavi/enable-serde-with-multi branch November 17, 2025 08:44
This was referenced Nov 19, 2025
gregorydemay pushed a commit that referenced this pull request Nov 21, 2025
## 🤖 New release

* `canhttp`: 0.3.0 -> 0.4.0
* `ic-canister-runtime`: 0.1.0
* `ic-agent-canister-runtime`: 0.1.0
* `ic-pocket-canister-runtime`: 0.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `canhttp`

<blockquote>

## [0.4.0] - 2025-11-21

### Added

- Add `JsonRpcHttpLayer` which combines the `HttpConversionLayer`,
`JsonConversionLayer` and `ConsistentJsonRpcIdFilter` middlewares into a
single convenient-to-use layer
([#46](#46))
- Add example canisters demonstrating JSON-RPC functionalities and
parallel calls ([#48](#48))

### Changed

- Bump `ic-cdk` to v0.19.0
([#40](#40))

### Fixed

- Missing optional dependency on `serde` for `multi` feature
([#47](#47))

[0.4.0]:
https://github.com/dfinity/canhttp/compare/canhttp-0.3.0..canhttp-0.4.0
</blockquote>

## `ic-canister-runtime`

<blockquote>

## [0.1.0] - 2025-11-21

### Added

- Add helper methods to `CyclesWalletRuntime`
([#44](#44))
- Add READMEs and examples
([#42](#42))
- Add `StubRuntime` ([#41](#41))
- Add `CyclesWalletRuntime`
([#37](#37))
- Add `Runtime` crate and `IcRuntime` implementation
([#35](#35))

[0.1.0]:
https://github.com/dfinity/canhttp/releases/tag/ic-canister-runtime-v0.1.0
</blockquote>

## `ic-agent-canister-runtime`

<blockquote>

## [0.1.0] - 2025-11-21

### Added

- Add `AgentRuntime` ([#36](#36))

[0.1.0]:
https://github.com/dfinity/canhttp/releases/tag/ic-agent-canister-runtime-v0.1.0
</blockquote>

## `ic-pocket-canister-runtime`

<blockquote>

## [0.1.0] - 2025-11-21

### Added

- Add `ExecuteHttpOutcallMocks` trait and support for PocketIC live mode
([#43](#43))
- Add READMEs and examples
([#42](#42))
- Add `PocketIcRuntime` and mock HTTP mock infrastructure
([#38](#38))

[0.1.0]:
https://github.com/dfinity/canhttp/releases/tag/ic-pocket-canister-runtime-v0.1.0
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants