feat: use ic-ref master for response authentication support#67
Merged
2 commits merged intoresponse-authenticationfrom Oct 22, 2020
Merged
feat: use ic-ref master for response authentication support#672 commits merged intoresponse-authenticationfrom
2 commits merged intoresponse-authenticationfrom
Conversation
ghost
requested a review
from 
p-shahi
approved these changes
Oct 22, 2020
Contributor
|
Looks like ic-ref expects the spec version to be |
|
Netlify deployed agent-rust as draft Link: https://5f91d9dc49abe5009c7c7e70--agent-rust.netlify.app |
Contributor
I’d say The implementation there is currently identical to the one on |
ghost
pushed a commit
that referenced
this pull request
Nov 18, 2020
* feat: use ic-ref master for response authentication support (#67) * Use ic-ref master for response authentication support * update for expected IC version * Use Certification ic-ref feature branch See also PR https://github.com/dfinity-lab/ic-ref/pull/167 * Only build ic-ref * Build less from ic-ref * Try to decode agent HttpError plan text values (display as text, not as array of ints) * wip * checkpoint: signature verification failed * trying to pass signature check * DER encoding * Revert "DER encoding" This reverts commit 795850f. * no extra space in hex dump * checkpoint: paths use BytesBuf * StateTreePath * panic if read_endpoint even succeeds * format * ignore two unit tests that need to be updated with new responses * clippeh * Add a test case for request id calculation with arrays * Update ic-ref instructions for generating request id * 2 more tests * checkpoint (compiles) * checkpoint: not panicking * checkpoint: empty array test passes * checkpoint: request id tests pass * fix 1234 = 0x4d2 not 0x3d2 * enum-based rather than trait-based * disable clippy warning because the proposed fix causes a different kind of error" * wip * checkpoint all request unit tests pass * remove old comments * ValueEncoder * streamline ElementEncoder creation * output certificate bytes * wip fixing up tests * (temporarily merge in hash tree stuff) * TreeHash deserialization * deserialize certificate; * extract request status from read_state certificate * refactor: convert_read_state_to_request_status * ignore tests because they need a different mocked response: agent_test call, call_rejected * format - hash_tree * format * ElementEncoder -> Hasher * Remove call and call_rejected agent tests, because they are nontrivial to mock, and are covered by integration tests. * Remove support for maps as requests. This didn't work anyway, and its removal simplifies the request id calculation a little * fix warnings * format * Hasher::Struct direct * &mut not ref mut * fix warning; * fmt * Debug decoding for HttpError (plain text) * why is it not using the Debug formatter * test against release-0.13 * clippy * force CI build * format * do not print certificate * path not found in certificate -> status unknown * Revert "format - hash_tree" This reverts commit 5b0099c. * Revert "TreeHash deserialization" This reverts commit 45ceefb. * Revert "(temporarily merge in hash tree stuff)" This reverts commit c5dc478. * Use new HashTree * refactor into methods; * Disable dead code warning for the digest method * better errors * format * cleanup * cleanup: read_state returns Certificate * use Label rather than StateTreePath * format * cleanup * update expected ic ref version * Remove Some() around content type in error message * grammar * remove unnecessary clippy directive * simplify vec -> label * fmt * From code review: remove SyncContent::RequestStatusRequest * From code review: DRY for LookupResult handling * lookup_value -> lookup_path Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.