Skip to content

Make CollectDeclaredReferences target incremental #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeyTeplyakov wants to merge 1 commit into from
Closed

Make CollectDeclaredReferences target incremental #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Package/build/ReferenceTrimmer.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
<CompilerVisibleProperty Include="EnableReferenceTrimmerDiagnostics"/>
</ItemGroup>

<Target Name="CollectDeclaredReferences" DependsOnTargets="ResolveAssemblyReferences;PrepareProjectReferences" Condition="'$(EnableReferenceTrimmer)' != 'false'">
<Target Name="CollectDeclaredReferences"
DependsOnTargets="ResolveAssemblyReferences;PrepareProjectReferences"
Condition="'$(EnableReferenceTrimmer)' != 'false'"
Inputs="$(MSBuildProjectFullPath);$(ProjectAssetsFile)"
Copy link
Copy Markdown
Owner

@dfederm dfederm Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more inputs than this

Outputs="$(MSBuildProjectDirectory)\$(IntermediateOutputPath)_ReferenceTrimmer_DeclaredReferences.tsv">
Copy link
Copy Markdown
Contributor

@stan-sz stan-sz Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Outputs="$(MSBuildProjectDirectory)\$(IntermediateOutputPath)_ReferenceTrimmer_DeclaredReferences.tsv">
Outputs="$([System.IO.Path]::GetFullPath('$(IntermediateOutputPath)_ReferenceTrimmer_DeclaredReferences.tsv'))">

<PropertyGroup>
<_ReferenceTrimmerDeclaredReferencesFile>$([System.IO.Path]::GetFullPath('$(IntermediateOutputPath)_ReferenceTrimmer_DeclaredReferences.tsv'))</_ReferenceTrimmerDeclaredReferencesFile>
<_ReferenceTrimmerUsedReferencesFile>$([System.IO.Path]::GetFullPath('$(IntermediateOutputPath)_ReferenceTrimmer_UsedReferences.log'))</_ReferenceTrimmerUsedReferencesFile>
Expand Down
3 changes: 3 additions & 0 deletions src/Tasks/CollectDeclaredReferencesTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,9 @@ private static void SaveDeclaredReferences(IReadOnlyList<DeclaredReference> decl
string existing = File.ReadAllText(filePath);
if (string.Equals(existing, newContent, StringComparison.OrdinalIgnoreCase))
{
// Touch the file so that MSBuild's Inputs/Outputs incrementality check
// sees a fresh timestamp and can skip the target on subsequent builds.
File.SetLastWriteTimeUtc(filePath, DateTime.UtcNow);
Copy link
Copy Markdown
Contributor

@stan-sz stan-sz Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole point of the if check is not to touch the timestamp if the file is identical, so this line should be reverted.

Copy link
Copy Markdown
Owner

@dfederm dfederm Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then incrementality never works for this target

Copy link
Copy Markdown
Owner

@dfederm dfederm Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but with the touch then the compiler's inputs changed and it triggers a recompile....

return;
}
}
Expand Down