Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codesign and notarize release build. Enable utilizing SafeDITool installed via brew. #37

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Codesign and notarize release build. Enable utilizing SafeDITool installed via brew. #37

merged 3 commits into from
Jan 30, 2024

Conversation

dfed
Copy link
Owner

@dfed dfed commented Jan 23, 2024 •
edited
Loading

This PR was tested by running this script in ci. It works!

I also made SafeDIGenerator capable of utilizing a brew-installed external installed safeditool.

@dfed dfed self-assigned this Jan 23, 2024
@dfed dfed force-pushed the dfed--codesign branch 10 times, most recently from 20099ea to c0915f5 Compare January 24, 2024 01:48
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25a40e0) 99.54% compared to head (7056146) 99.54%.

❗ Current head 7056146 differs from pull request most recent head 96b0d02. Consider uploading reports for the commit 96b0d02 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   99.54%   99.54%   -0.01%     
==========================================
  Files          40       40              
  Lines       10664    10656       -8     
==========================================
- Hits        10615    10607       -8     
  Misses         49       49

see 1 file with indirect coverage changes

@dfed dfed changed the title Enable publish.yml to codesign and notarize Enable publish.yml to codesign and notarize. Create SafeDIExternalGenerator plugin. Jan 24, 2024
@dfed dfed force-pushed the dfed--codesign branch 2 times, most recently from a528ee4 to 43a6d1a Compare January 29, 2024 23:12
@dfed dfed changed the title Enable publish.yml to codesign and notarize. Create SafeDIExternalGenerator plugin. Enable publish.yml to codesign and notarize. Enable SafeDIGenerator plugin to utilize brew install. Jan 30, 2024
@dfed dfed marked this pull request as ready for review January 30, 2024 00:39
@dfed dfed changed the title Enable publish.yml to codesign and notarize. Enable SafeDIGenerator plugin to utilize brew install. Codesign and notarize release build. Enable utilizing SafeDITool installed via brew. Jan 30, 2024
@dfed dfed merged commit 6c4be75 into main Jan 30, 2024
3 of 9 checks passed
@dfed dfed deleted the dfed--codesign branch January 30, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dfed dfed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfed