Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSV file for dependent module info rather than a list #113

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

dfed
Copy link
Owner

@dfed dfed commented Oct 3, 2024

Instead of having a moduleInfoPaths: [String] property, we instead use a dependentModuleInfoFilePath: String?. This limit the amount of information needed to be sent to the CLI.

@dfed dfed self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.52%. Comparing base (b50ff74) to head (0101b2d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          33       33           
  Lines        2713     2724   +11     
=======================================
+ Hits         2700     2711   +11     
  Misses         13       13           
Files with missing lines Coverage Δ
Sources/SafeDITool/SafeDITool.swift 98.78% <100.00%> (+0.08%) ⬆️

@dfed dfed marked this pull request as ready for review October 3, 2024 06:27
@dfed dfed merged commit d20e9a6 into main Oct 3, 2024
13 checks passed
@dfed dfed deleted the dfed--module-info-dependency branch October 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant