Implement Crossbows #957
Merged
Implement Crossbows #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandertv
reviewed
Dec 14, 2024
DaPigGuy
reviewed
Dec 15, 2024
89 tasks
DaPigGuy
reviewed
Dec 16, 2024
DaPigGuy
reviewed
Dec 22, 2024
DaPigGuy
reviewed
Dec 24, 2024
Sandertv
reviewed
Dec 24, 2024
DaPigGuy
reviewed
Dec 25, 2024
Add middle loading sound and potentially fix loading
Sandertv
reviewed
Jan 3, 2025
server/world/sound/item.go
Outdated
Comment on lines
54
to
66
| type CrossbowLoadingStart struct{ sound } | ||
|
|
||
| // CrossbowLoadingMiddle is a sound played while a crossbow is loading and when a crossbow stops loading. | ||
| type CrossbowLoadingMiddle struct{ sound } | ||
|
|
||
| // CrossbowQuickChargeLoadingStart is a sound played when a crossbow with Quick Charge starts to load. | ||
| type CrossbowQuickChargeLoadingStart struct{ sound } | ||
|
|
||
| // CrossbowQuickChargeLoadingMiddle is a sound played while a crossbow with Quick Charge is loading. | ||
| type CrossbowQuickChargeLoadingMiddle struct{ sound } | ||
|
|
||
| // CrossbowQuickChargeEnd is a sound played when a crossbow with Quick Charge stops loading. | ||
| type CrossbowQuickChargeEnd struct{ sound } |
There was a problem hiding this comment.
I would try to combine some of these sounds into one type. Add a QuickCharge bool field to halve the number of types, them maybe some Stage field to indicate start vs middle vs end.
Sandertv
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement crossbows and multishot enchantment.