feat(gitlab): full group retrieval #4408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CorentinPtrl <[email protected]>
Signed-off-by: CorentinPtrl <[email protected]>
cardoe
approved these changes
Nov 25, 2025
cardoe
added a commit
to cardoe/dex
that referenced
this pull request
Dec 9, 2025
Contributor
|
To further this along, I've pulled this PR into build that I made at https://github.com/cardoe/dex/releases/tag/v2.44.90 You can grab the container to test with at ghcr.io/cardoe/dex:v2.44.90 and report back on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements full group retrieval for the GitLab connector. and adds all the mappings of GitLab access levels into group-permission suffixes.
What this PR does / why we need it
Implement fetching all groups and per-group membership from the GitLab API so Dex can return the complete set of groups for a user (not only those in the
/oauth/userinforesponse). See upstream discussion: https://gitlab.com/gitlab-org/gitlab/-/issues/340905. The filtering viagroupswill prevent overly large tokens. Full group retrieval now requires theread_apiscope.