db: email comparison should be case insensitive #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why aren't we instead preventing mixed case and doing the DB migration? |
|
Fine doing it both ways. Thought it might be rough to have a migration with a rolling upgrade. You'd be able to create a user with an invalid email on an old work, for instance. |
|
I think this needs to be two stages:
after people have installed that release they can do a fix.
On Fri, Feb 26, 2016 at 2:35 PM Eric Chiang [email protected]
|
When reading migrations from files, sql-migrate attempts to split SQL statements. The parsing logic does not handle $BODY$ statements and broke when the migration included one. Replace go-bindata with a small migration generation script and use in memory migrations instead.
ericchiang
force-pushed
the
case_insensitive_emails
branch
from
c6f4a90
to
2a0cc47
Compare
ericchiang
force-pushed
the
case_insensitive_emails
branch
from
84cee2e
to
01a2454
Compare
|
ready for review @bobbyrullo |
|
Minor issues, otherwise LGTM! |
ericchiang
added a commit
that referenced
this pull request
Mar 3, 2016
db: email comparison should be case insensitive
This was referenced Mar 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to add a few tests and some additional documentation, but this provides a fix for #338 that does not require a database migration (e.g. lower casing all of the emails currently in the DB).
fixes #338