Override OIDC provider discovered claims #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <[email protected]>
Signed-off-by: m.nabokikh <[email protected]>
nabokihms
force-pushed
the
oidc-provider-override-discovery
branch
from
4ffe616
to
054261f
Compare
sagikazarmark
approved these changes
Jan 10, 2024
Signed-off-by: m.nabokikh <[email protected]>
|
Adding a warning does make sense to me. Added. |
nabokihms
added a commit
to dexidp/website
that referenced
this pull request
Jan 10, 2024
Update the doc after merging dexidp/dex#3267 Signed-off-by: Maksim Nabokikh <[email protected]>
kerberos727
added a commit
to kerberos727/dex-project
that referenced
this pull request
Aug 23, 2024
Update the doc after merging dexidp/dex#3267 Signed-off-by: Maksim Nabokikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The feature allows to override specific endpoints discovered by the go-oidc library.
The exemplary case is when you want to request the token internally in Kubernetes by using the service discovery DNS-based name without accessing the public address of an IdP.
What this PR does / why we need it
Closes #2147
Special notes for your reviewer
All the provider options could be added to be able to be overridden in the future.