Store offline sessions only if they were requested by the user #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MM53 <[email protected]>
… during login Signed-off-by: MM53 <[email protected]>
MM53
force-pushed
the
fix-offline-sessions
branch
from
b4da7cc
to
aefc607
Compare
nabokihms
approved these changes
Oct 19, 2023
| @@ -539,6 +539,17 @@ func (s *Server) finalizeLogin(identity connector.Identity, authReq storage.Auth | |||
| return returnURL, false, nil | |||
| } | |||
|
|
|||
| offlineAccessRequested := false | |||
There was a problem hiding this comment.
NIT
Suggested change
| offlineAccessRequested := false | |
| var offlineAccessRequested bool |
mdpradeep
pushed a commit
to mdpradeep/dex
that referenced
this pull request
Oct 20, 2023
…p#3125) Signed-off-by: MM53 <2821Signed-off-by: MM53 <[email protected]> Signed-off-by: Pradeep Mudlapur <[email protected]>
jtfrey
pushed a commit
to jtfrey/dex
that referenced
this pull request
Oct 20, 2023
…p#3125) Signed-off-by: MM53 <2821Signed-off-by: MM53 <[email protected]> Signed-off-by: Jeffrey Frey <[email protected]>
mdpradeep
added a commit
to mdpradeep/dex
that referenced
this pull request
Oct 20, 2023
dexidp#3125)" This reverts commit 5829ba7.
orange-hbenmabrouk
pushed a commit
to orange-hbenmabrouk/dex
that referenced
this pull request
Oct 23, 2023
…p#3125) Signed-off-by: MM53 <2821Signed-off-by: MM53 <[email protected]>
orange-hbenmabrouk
pushed a commit
to orange-hbenmabrouk/dex
that referenced
this pull request
Oct 23, 2023
…p#3125) Signed-off-by: MM53 <2821Signed-off-by: MM53 <[email protected]> Signed-off-by: Houssem Ben Mabrouk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Create offline sessions only if they are supported by the connector and if the user requests it with the scope
offline_access.Extend handler tests to verify this behavior.
What this PR does / why we need it
This PR resolves the bug described in #3124
Special notes for your reviewer
Does this PR introduce a user-facing change?