Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetClient grpc service #2972

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

marcofranssen
Copy link
Contributor

@marcofranssen marcofranssen commented May 26, 2023

Overview

What this PR does / why we need it

This PR adds a GetClient grpc endpoint which I need to implement a Terraform provider
marcofranssen/terraform-provider-dexidp#7

Special notes for your reviewer

Does this PR introduce a user-facing change?


server/api.go Outdated Show resolved Hide resolved
server/api.go Outdated Show resolved Hide resolved
server/api.go Outdated Show resolved Hide resolved
@marcofranssen marcofranssen force-pushed the get-client-grpc branch 2 times, most recently from 0acaaee to 33096d0 Compare June 1, 2023 10:06
@marcofranssen marcofranssen force-pushed the get-client-grpc branch 2 times, most recently from 3250fb7 to c323a74 Compare July 2, 2023 20:38
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcofranssen!

@nabokihms nabokihms merged commit 895b166 into dexidp:master Jul 6, 2023
@marcofranssen
Copy link
Contributor Author

marcofranssen commented Sep 6, 2023

When can we expect a release with this feature? So I can finish this implementation

marcofranssen/terraform-provider-dexidp#7

The last release has been a while https://github.com/dexidp/dex/blob/api/v2.1.0/api/v2/api_grpc.pb.go

@nabokihms
Copy link
Member

October something I believe.

palexster pushed a commit to palexster/dex that referenced this pull request Oct 4, 2023
michaelliau pushed a commit to FlockFreight/dex that referenced this pull request Oct 4, 2023
@marcofranssen
Copy link
Contributor Author

marcofranssen commented Dec 15, 2023

Its December now. Any update on when a release is planned?

@marcofranssen
Copy link
Contributor Author

Is it possible to also create a release using the api/v2.x tagging so the change also shows up in https://pkg.go.dev/github.com/dexidp/dex/api/v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants