Godeps: update coreos/go-oidc to include OIDC race condition fixes #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update github.com/coreos/go-oidc/... to include coreos/go-oidc#17 which fixes a race condition in the OIDC connector.
Closed
ericchiang
added a commit
that referenced
this pull request
Dec 15, 2015
Godeps: update coreos/go-oidc to include OIDC race condition fixes
ericchiang
added a commit
to ericchiang/dex
that referenced
this pull request
Dec 17, 2015
In dexidp#210 a field name in the provider config was corrected. However the old, and incorrect, value was hard coded in the tests. This change updates the test case to hold the correct field name. There are no other references to the old name in dex or its vendored packages.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
github.com/coreos/go-oidc/...to include coreos/go-oidc#27 which fixes a race condition in the OIDC connector when syncing provider configurations.