Fix HTTPS server listener regression #2018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <[email protected]>
Member
sagikazarmark
left a comment
sagikazarmark
left a comment
There was a problem hiding this comment.
I don't fully agree with this way. Also, I don't see the actual bug what caused the HTTPS server to stop working. Is it because we always called Serve and never ServeTLS?
Merged
Member
|
Fixed in #2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: m.nabokikh [email protected]
Overview
What this PR does / why we need it
Fix of the regression of #1963
The HTTPS server of dex built from the master branch listens on a port without TLS encryption.
Special notes for your reviewer
Does this PR introduce a user-facing change?
It is the fix for the previous PR with a new feature, so we should not add anything new to the release message.