Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor #1745

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Remove vendor #1745

merged 4 commits into from
Jun 30, 2020

Conversation

sagikazarmark
Copy link
Member

Fixes #1597

JoelSpeed
JoelSpeed approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just manually verified that everything still works (as far as I can tell), noticed while I was doing that that our make target for the docker image requires sudo, I think we should probably drop that as we shouldn't strictly need sudo for it

@sagikazarmark
Copy link
Member Author

Just manually verified that everything still works (as far as I can tell), noticed while I was doing that that our make target for the docker image requires sudo, I think we should probably drop that as we shouldn't strictly need sudo for it

I'm gonna address that in a different PR (as well as add a Docker job to actions pushing to dockerhub)

@sagikazarmark sagikazarmark merged commit eef8c0a into master Jun 30, 2020
@sagikazarmark sagikazarmark deleted the remove-vendor branch June 30, 2020 19:50
xtremerui pushed a commit to concourse/dex that referenced this pull request Oct 5, 2020
upstream dex release: 2.25.0
45381b5 
The official docker release for this release can be pulled from

    dexidp/dex:v2.25.0

**Features:**

- Move the API package to a separate module (dexidp#1741, @sagikazarmark)
- OAuth2 Device Authorization Grant (dexidp#1706, @justin-slowik)
- Support username, email and groups claim in OIDC connector (dexidp#1634, @xtremerui)

**Bugfixes:**

- Add offline_access scope in microsoft connector, if required (dexidp#1441, @jimmythedog)
- Allow the google connector to work without a service account (dexidp#1720, @candlerb)

**Minor changes:**

- Remove vendor (finally) (dexidp#1745, @sagikazarmark)
- Fix the LDAP example (dexidp#1762, @heidemn-faro)
- Relocate the example app (dexidp#1764, @sagikazarmark)
xtremerui pushed a commit to concourse/dex that referenced this pull request Nov 5, 2020
upstream dex release: 2.25.0
f63a875 
The official docker release for this release can be pulled from

    dexidp/dex:v2.25.0

**Features:**

- Move the API package to a separate module (dexidp#1741, @sagikazarmark)
- OAuth2 Device Authorization Grant (dexidp#1706, @justin-slowik)
- Support username, email and groups claim in OIDC connector (dexidp#1634, @xtremerui)

**Bugfixes:**

- Add offline_access scope in microsoft connector, if required (dexidp#1441, @jimmythedog)
- Allow the google connector to work without a service account (dexidp#1720, @candlerb)

**Minor changes:**

- Remove vendor (finally) (dexidp#1745, @sagikazarmark)
- Fix the LDAP example (dexidp#1762, @heidemn-faro)
- Relocate the example app (dexidp#1764, @sagikazarmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

@bonifaido bonifaido bonifaido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit vendoring
3 participants
@sagikazarmark @bonifaido @JoelSpeed