Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prompt configurable for oidc offline_access #1656

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

commixon
Copy link
Contributor

@commixon commixon commented Feb 19, 2020

For OIDC offline_access, the prompt used to be hardcoded to consent:

opts = append(opts, oauth2.AccessTypeOffline, oauth2.SetAuthURLParam("prompt", "consent"))

However, in some OIDC provides this value is not supported (e.g. OneLogin: https://developers.onelogin.com/openid-connect/api/id-token) where it states:

Optional. If used must be set to one of the following:

  • login - The user will be prompted with a login dialog.
  • none - The user will not be prompted with a login dialog. If they do not have a current session a login_required error will be returned.

This adds the promptType param, set by default to consent but with the ability to explicitly set it in the config and override it.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoelSpeed JoelSpeed merged commit 30ea963 into dexidp:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants