Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelogin-activedirectory.md for credential plugin mode #1648

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

int128
Copy link
Contributor

@int128 int128 commented Feb 12, 2020

This will update the document of "Integration kubelogin and Active Directory".

Now kubelogin supports credential plugin mode (new) and standalone mode (old). Currently the document uses standalone mode and this PR will replace it with credential plugin mode. It allows better user experience because user do not need to run kubelogin command explicitly.

Thanks the original author @okamototk.

Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bonifaido bonifaido merged commit cf4f88a into dexidp:master Feb 12, 2020
@int128 int128 deleted the patch-1 branch March 3, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants