Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support username, email and groups claim in OIDC connector #1634

Merged
merged 9 commits into from
Sep 8, 2020
Merged

Support username, email and groups claim in OIDC connector #1634

merged 9 commits into from
Sep 8, 2020

Commits on Aug 11, 2020

  1. Make OIDC username key configurable 

    Signed-off-by: Josh Winters <[email protected]>
Co-authored-by: Mark Huang <[email protected]>
Signed-off-by: Rui Yang <[email protected]>
    @mhuangpivotal
    2 people authored and Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9a4e0fc View commit details
    Browse the repository at this point in the history

  2. default to preferred_username claim 

    Signed-off-by: Rui Yang <[email protected]>
    Rui Yang authored and Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d9afb7e View commit details
    Browse the repository at this point in the history

  3. add tests when preferred username key is not set 

    Signed-off-by: Rui Yang <[email protected]>
    Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4812079 View commit details
    Browse the repository at this point in the history

  4. check if upstream contains preferrend username claim first 

    Signed-off-by: Rui Yang <[email protected]>
Signed-off-by: Rui Yang <[email protected]>
    Rui Yang authored and Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    52c39fb View commit details
    Browse the repository at this point in the history

  5. Add parameter configuration to override email claim key 

    Signed-off-by: Rui Yang <[email protected]>
    @cyrilix
    cyrilix authored and Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    61312e7 View commit details
    Browse the repository at this point in the history

  6. Add groupsClaimMapping to the OIDC connector 

    The groupsClaimMapping setting allows one to specify which claim to pull
group information from the OIDC provider.  Previously it assumed group
information was always in the "groups" claim, but that isn't the case
for many OIDC providers (such as AWS Cognito using the "cognito:groups"
claim instead)

Signed-off-by: Scott Lemmon <[email protected]>
Signed-off-by: Rui Yang <[email protected]>
    @Lemmons
    Lemmons authored and Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a783667 View commit details
    Browse the repository at this point in the history

  7. Combine dexidp#1691 and dexidp#1776 to unify OIDC provider claim mapping 

    add tests for groups key mapping

Signed-off-by: Rui Yang <[email protected]>
    Rui Yang committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    41207ba View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. update oidc documentation and email claim err msg 

    Signed-off-by: Rui Yang <[email protected]>
    Rui Yang committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0494993 View commit details
    Browse the repository at this point in the history

  2. revert changes for user id and user name 

    Signed-off-by: Rui Yang <[email protected]>
    Rui Yang committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    058202d View commit details
    Browse the repository at this point in the history