Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenShift connector #1599

Merged
merged 10 commits into from
Jan 1, 2020
Merged

OpenShift connector #1599

merged 10 commits into from
Jan 1, 2020

Conversation

sabre1041
Copy link
Contributor

Support for authenticating against OpenShift

@sabre1041
Copy link
Contributor Author

Failed build unrelated to changes introduced by this feature

@bonifaido
Copy link
Member

Could you please fix the formatting? (I just reran the tests and they seem to be okay now):

The following files are not formatted correctly: connector/openshift/openshift_test.go

@bonifaido bonifaido self-assigned this Dec 21, 2019
bonifaido
bonifaido requested changes Dec 21, 2019
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Actions CI reports the formatting errors here in the review, those need to be fixed.

@sabre1041
Copy link
Contributor Author

@bonifaido corrected errors in tests

bonifaido
bonifaido approved these changes Dec 22, 2019
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request otherwise LGTM!

Please extend the list of connectors as well in the main README: https://github.com/dexidp/dex#connectors

@sabre1041
Copy link
Contributor Author

@bonifaido added to list of connectors

@sabre1041
Copy link
Contributor Author

@bonifaido I am improving the security model today and will advise when it should be good to review again

@sabre1041 sabre1041 changed the title OpenShift connector WIP: OpenShift connector Dec 25, 2019
@sabre1041 sabre1041 changed the title WIP: OpenShift connector OpenShift connector Dec 26, 2019
@sabre1041
Copy link
Contributor Author

@bonifaido PR should be ready to merge upon your review again

@sabre1041
Copy link
Contributor Author

@bonifaido any chance you would be able to review?

@bonifaido
Copy link
Member

Yes, just got the chance again, sorry for the delay (holiday time!).

@bonifaido bonifaido merged commit 6318c10 into dexidp:master Jan 1, 2020
@sabre1041 sabre1041 deleted the openshift-connector branch January 1, 2020 11:57
@bonifaido
Copy link
Member

And thanks for the PR, nicely done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

Assignees

@bonifaido bonifaido

Labels
area/connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabre1041 @bonifaido