Add github actions CI flow #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
github-actions
branch
18 times, most recently
from
7039afb
to
d8c0772
Compare
sagikazarmark
force-pushed
the
github-actions
branch
11 times, most recently
from
0b40215
to
7d62eba
Compare
sagikazarmark
force-pushed
the
github-actions
branch
5 times, most recently
from
4f1c9f6
to
b3e91a7
Compare
sagikazarmark
force-pushed
the
github-actions
branch
from
b3e91a7
to
5d2529f
Compare
Closed
sagikazarmark
force-pushed
the
github-actions
branch
from
5e108fd
to
3c7593f
Compare
bonifaido
reviewed
Dec 9, 2019
| @@ -1,610 +0,0 @@ | |||
| # OpenLDAP Core schema | |||
There was a problem hiding this comment.
Weren't these files used at all?
There was a problem hiding this comment.
The previous tests started slapd with a clean config. These schemas are already loaded into the docker version.
bonifaido
approved these changes
Dec 12, 2019
|
🎉 thanks, this is awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first version.
I plan to do further improvements around test running in subsequent PRs:
Fixes #1414
Fixes #1557
Update: I've rewritten the LDAP tests to use docker and https://github.com/osixia/docker-openldap instead, because I couldn't get it working otherwise (hence the giant changeset).