storage/kubernetes: Removing Kubernetes TPR support #1517
Conversation
|
I'll defer to @JoelSpeed on this one 😉 |
There was a problem hiding this comment.
No one should be using TPRs anymore as Kubernetes introduced CRDs about 2 years ago. I would however be tempted to leave the migration instructions for 1 release after we remove the code. If you haven't already migrated and we remove the migration instructions, you'll be a bit stuck!
Can we keep the migration instructions and add a TODO to remove them after the next release?
In this PR there is a link in the storage docs to v2.17.0 as the last version to support TPR. If we're removing support for TPR in the next release, perhaps instead of keeping the migration instructions in the current documentation we simply add another line with a link to the old migration documentation ... and either remove I could see it either way, just let me know |
|
@venezia You make a very good point, how about we just add a link to the old migration documentation saying something like "Note: If you have not migrated away from TPRs, please see the [documentation] and migrate before upgrading Dex" |
Third Party Resources (TPR) have been removed from Kubernetes for roughly 2 years. This commit removes the support dex had for them. Documentation has been updated to reflect this and to instruct users on how to migrate from TPR-powered dex environment to a Custom Resource Defintion (CRD) based one that dex > v2.17 will support
|
@JoelSpeed I updated the documentation a bit, removed the legacy script, squashed commits and force pushed back to my branch. LMK if this works for you - thanks! |
|
Just for the record, I've been publishing a release while you've been discussing this. So, whatever was true for TPR in 2.17.0 probably is true for 2.18.0 as well 😄 |
|
hah - well that's the breaks :) |
I don't think this should cause an issue, the docs have been removed and people should notice it stopping working eventually 🤷♂ |
storage/kubernetes: Removing Kubernetes TPR support
Part of fixing #1513 - this has a significant amount of code change and wanted to push this through before adding a flag to CRD creation.