make userName configurable #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
May 31, 2019
|
@flarno11 thanks for bearing with me. Would you mind squashing these commits? 😃 Happy to mash the button then. |
|
@srenatus I've squashed the commits |
srenatus
approved these changes
Jun 4, 2019
|
@srenatus cool thanks! is there a roadmap for a next release already? |
|
#1458 wouldn't go so far to call it a road map, but this will happen soon, I suppose 😄 |
|
I've been meaning to review #1454 but haven't found the time yet... |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
make userName configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is needed to support OpenID providers that don't have a "name" claim