microsoft: option for group UUIDs instead of name and group whitelist

[maksd]

This PR add a useGroupUUID option to return groups UUIDs instead of names. And, it change the behavior of the groups option to not only allow user member of a particular group but also act as a whitelist for the groups return in the claim.

The main reason for using group UUIDs, is that group names are not unique in Microsoft Azure AD.

[ericchiang]

Can we make this an enum instead of a boolean? Something like:

groupNameFormat: id # defaults to name

Also are these actually UUIDs? (https://en.wikipedia.org/wiki/Universally_unique_identifier) That's a pretty specific format and I only see "id" referenced in the API 😃

[maksd]

@ericchiang Yes I can change it for an enum. About the "uuids", I took it from the Microsoft Graph documentation for the directoryObject resource type :

Property	Type	Description
id	String	A Guid that is the unique identifier for the object; for example, 12345678-9abc-def0-1234-56789abcde. Key. Not nullable. Read-only.

But I will change it for "id" instead.

[ericchiang]

please squash your commits 😃

[srenatus]

Could you rebase this once more, please? I had merged a change refactoring the group filtering into a helper method that affected this PR, sorry. 😃

[maksd]

Hi @srenatus, rebase done.

[srenatus]

Thank you 🎉 That's a nice contribution.

Just one nitpick. I'm afraid this connector has no tests, but it's OK if you don't want to be the person reducing that tech debt. If, however, you'd like to add some, that would be very welcome 😉

[maksd]

@srenatus nit fixed, thanks for the catch. About the tests, I would be happy to do it, but it will have to wait a bit, maybe in another PR, or unless someone else beat me to it. :)