Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: support for group whitelist #1436

Merged
merged 2 commits into from
May 8, 2019
Merged

gitlab: support for group whitelist #1436

merged 2 commits into from
May 8, 2019

Conversation

bonifaido
Copy link
Member

The GitLab connector was missing the group/org/team filtering as in BitBucket or GitHub connector. In this PR I would like to cure this absence.

srenatus
srenatus reviewed Apr 29, 2019
View reviewed changes
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a great addition.

Do we have tests for this connector that could be expanded?

Would you think factoring out some group-related helper used in all three connectors would make sense?

@bonifaido
Copy link
Member Author

bonifaido commented May 1, 2019 •
edited
Loading

Yeah sorry, I haven't extended the test cases (I saw that there are tests for GitLab), I surely will.
I think at least the BitBucket and GitHub connector has the very same group/team/org filtering functionality, I will check how I can extract the code parts which do this logic.

@bonifaido
Copy link
Member Author

I was wrong, there are no GitLab connector tests yet, I will add a few :)

srenatus
srenatus approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! 😃

I'm not near a real computer, so I'll leave the merge for someone else.

@bonifaido
Copy link
Member Author

How can we get this merged? :)

@srenatus
Copy link
Contributor

srenatus commented May 8, 2019

I'll take a leap of faith... 😉

@srenatus srenatus merged commit d8f9634 into dexidp:master May 8, 2019
@bonifaido bonifaido deleted the gitlab-groups branch May 8, 2019 07:58
@bonifaido
Copy link
Member Author

Thank you! 👍

mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
@srenatus
Merge pull request dexidp#1436 from bonifaido/gitlab-groups
7ddfcfb 
gitlab: support for group whitelist, add tests
@kenperkins kenperkins mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenatus srenatus srenatus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonifaido @srenatus