server: add metrics for CORS handlers. #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
approved these changes
May 12, 2019
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
server: add metrics for CORS handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am troubleshooting an issue with my Dex setup where tokens fail to get refreshed (due to getting a 401 back on
/token), and I realized that there are no metrics for the/tokenendpoint, which is a bit annoying as it makes it harder to track how frequently this issue is happening over time, is it the first time it happens, etc. So I figured it be nice to add the same basic instrumentation that other handlers benefit from to the CORS handlers as well.