Update modules for go 1.11.4+ #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.11.3 changed how checksums are created in some cases, which caused failures building via modules. (ref golang/go#29278) Update the checksums for the failing modules. To catch this is the future, a modules build was added to the build matrix. I also noted that we were pinning the `.0` patchlevel of each go version which wouldn't have picked this up, updated it to build with the latest patch release.
srenatus
approved these changes
Feb 10, 2019
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Update modules for go 1.11.4+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11.3 changed how checksums are created in some cases, which caused
failures building via modules. (ref golang/go#29278)
Update the checksums for the failing modules.
To catch this is the future, a modules build was added to the build matrix. I
also noted that we were pinning the
.0patchlevel of each go version whichwouldn't have picked this up, updated it to build with the latest patch
release.