Skip redirection approval regression

[nabokihms]

Preflight Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.
• I am not looking for support or already pursued the available support channels without success.

Version

2.36.0

Storage Type

Kubernetes

Installation Type

Binary, Official Helm chart

Expected Behavior

I'd like to see a consent screen if a provider requested some of my personal data.

Actual Behavior

No consent screen.

Steps To Reproduce

Launch our demo application:

make build
make example
bin/dex examples/config-dev.yaml
bin/example-app

Additional Information

This is a regression after #2805 because of the following clause

dex/server/handlers.go

Line 526 in 2bb4896

if s.skipApproval || !authReq.ForceApprovalPrompt {

1. By default consent screen should always be shown
2. If the consent screen is off by settings, it is still possible to show it using the force approval prompt option.

Configuration

No response

Logs

No response

[sagikazarmark]

@nabokihms nice catch. Are you planning to provide a patch?

[nabokihms]

Yes, I will.