Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL support for storage #200

Closed
ericdai opened this issue Dec 4, 2015 · 6 comments
Closed

Add MySQL support for storage #200

ericdai opened this issue Dec 4, 2015 · 6 comments

Comments

@ericdai
Copy link

ericdai commented Dec 4, 2015

we are a mysql and ms sql server based company ,we did not use postgresql.
so I want to know if there is any plan to support mysql and MSSQL server?

@ericchiang
Copy link
Contributor

Adding additional backends isn't in the immediate roadmap. But, because dex uses gorp to construct queries and sql-migrate for migrations, other SQL flavors should work.

If you'd like to test MySQL or MSSQL server, I'm sure others would appreciate it!

To test other drivers, you'd need to alter:

  1. The database connection code here
  2. The migration dialect here

@bobbyrullo
Copy link
Contributor

I am pretty sure there are postgres specific features in there - some stuff
related to quoting in SQL statements comes to mind.

But yeah, like Eric said, supporting other backends is not a priority for
us over here.

On Mon, Dec 7, 2015 at 9:30 AM Eric Chiang [email protected] wrote:

Adding additional backends isn't in the immediate roadmap. But, because
dex uses gorp https://github.com/go-gorp/gorp to construct queries and
sql-migrate https://github.com/rubenv/sql-migrate for migrations, other
SQL flavors should work.

If you'd like to test MySQL or MSSQL server, I'm sure others would
appreciate it!

To test other drivers, you'd need to alter:

  1. The database connection code here
    https://github.com/coreos/dex/blob/2a1d32e6e8e983cebdb50999ddd5c2cc73a945e8/db/conn.go#L45
  2. The migration dialect here
    https://github.com/coreos/dex/blob/2a1d32e6e8e983cebdb50999ddd5c2cc73a945e8/db/migrate.go#L14


Reply to this email directly or view it on GitHub
#200 (comment).

bcwaldon pushed a commit to bcwaldon/dex that referenced this issue Dec 10, 2015
Check to make sure it's neccessary first.

fixes dexidp#200
@craigtracey
Copy link

This is a first (completely untested) pass at mysql support:
https://github.com/craigtracey/dex/tree/mysql-support

Early comments welcome.

@ericchiang
Copy link
Contributor

Cool!

I'll go ahead and reopen this issue. Feel free to submit a PR if you'd like to run against travis, but I imagine there are some overall organizational changes to the code we're going to need to discuss.

@ericchiang ericchiang reopened this Aug 2, 2016
@ericchiang ericchiang changed the title when support mysql? Add MySQL support for storage Aug 2, 2016
@rudolfv
Copy link

rudolfv commented May 30, 2019

@ericchiang It's been a while and was wondering what happened to this? Are you still open to PRs for adding MySQL support for storage?

@srenatus
Copy link
Contributor

#1485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants