Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when clicking the "looks like you've already registered link" invalid request #135

Closed
bobbyrullo opened this issue Sep 25, 2015 · 2 comments · Fixed by #183
Closed

when clicking the "looks like you've already registered link" invalid request #135

bobbyrullo opened this issue Sep 25, 2015 · 2 comments · Fixed by #183
Assignees
@bobbyrullo
Labels
area/usability kind/bug priority/P0 reviewed/needs more info

Comments

@bobbyrullo
Copy link
Contributor

from logs:
ERROR: Invalid auth request: missing 'openid' in 'scope'
@bobbyrullo bobbyrullo self-assigned this Sep 25, 2015
@stongo
Copy link
Contributor

stongo commented Nov 18, 2015

I'm going to try to fix this today. This function doesn't maintain the scope query params https://github.com/coreos/dex/blob/2a1d32e6e8e983cebdb50999ddd5c2cc73a945e8/server/register.go#L283

@bobbyrullo
Copy link
Contributor Author

Awesome - thanks @stongo

stongo added a commit to stongo/dex that referenced this issue Nov 18, 2015
@stongo
server: add scope to newLoginURLFromSession
7d0ecf9 
need to make sure the scope is present otherwise will be considered an invalid request

fixes dexidp#135
@stongo stongo mentioned this issue Nov 18, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbyrullo bobbyrullo

Labels
area/usability kind/bug priority/P0 reviewed/needs more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: add scope to newLoginURLFromSession stongo/dex
3 participants
@bobbyrullo @bcwaldon @stongo