allow responses w/o data envelope. workaround for #6 until #19 is done

[devvmh]

grep -r 'action.payload.data' src/ returns only these two lines now, so I believe this should cover people who have responses without a data envelope. I need someone to test this though before I feel happy merging it in. @mxmtsk would you be interested in trying this branch out with your project? I could merge this as 4.3.0 this week if it works for you.

[mxmtsk]

could you help me with how to build the new files in lib/ from your changes in src/? 😅

[devvmh]

I think the simplest way is to clone this repo to your localhost, and then run npm install and npm run build

Then you can change your project's package.json to say

"redux-crud-store": "/local/path/to/redux-crud-store",

Does that make sense?

[mxmtsk]

Got it to work. It works fine without a data envelope, but with the data envelope I had in before for testing purposes it throws

TypeError: originalPayload.delete is not a function

[devvmh]

Ah ha, excellent, thanks, that latest commit should fix that

[mxmtsk]

now it throws the error at TypeError: otherInfo.delete is not a function

[devvmh]

d'oh

[mxmtsk]

we're getting there...
.delete is not defined still but I changed it to

if ('data' in originalPayload) delete otherInfo.data;

Which works but results in the new error

[1]    TypeError: payload.forEach is not a function
[1]        at /Users/maxmitschke/work/wtc-web/node_modules/redux-crud-store/lib/reducers.js:74:17

[devvmh]

😢 I'll try again tomorrow morning. This file is weird. I don't know why there are two case FETCH_SUCCESS: lines

[devvmh]

I think that's yet another response format function that won't be solved
without enabling normalizr.

Are you able to change your ApiClient to ensure that the response data is
an array no matter what?

On Wed, Jul 20, 2016 at 6:55 PM Max Mitschke [email protected]
wrote:

we're getting there...
.delete is not defined still but I changed it to

if ('data' in originalPayload) delete otherInfo.data;

Which works but results in the new error

[1] TypeError: payload.forEach is not a function
[1] at /Users/maxmitschke/work/wtc-web/node_modules/redux-crud-store/lib/reducers.js:74:17

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVELDaiptWEW5dpO6LuvRon5BJacs7cks5qXf6XgaJpZM4JQYld
.