Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimizations in git flows #87

Merged
merged 65 commits into from
Feb 7, 2024
Merged

Conversation

subhashish-devtron
Copy link
Contributor

@subhashish-devtron subhashish-devtron commented Feb 7, 2024

#Fixes 88

Copy link

gitguardian bot commented Feb 7, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9190503 Triggered Username Password cbd5a5d pkg/git/RepositoryManagerIT_test.go View secret
9190503 Triggered Username Password 51743fc pkg/git/RepositoryManagerIT_test.go View secret
9190503 Triggered Username Password ab22c47 pkg/git/RepositoryManagerIT_test.go View secret
9190503 Triggered Username Password e8a34c6 pkg/git/RepositoryManagerIT_test.go View secret
6669478 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669479 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669480 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669481 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669482 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669483 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
6669484 Triggered PGP Private Key 9ffc8e7 vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kripanshdevtron kripanshdevtron changed the title chore: optimizations in git flows fix: optimizations in git flows Feb 7, 2024
@subhashish-devtron subhashish-devtron merged commit f2886d7 into main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance: Optimization in poller for fetching commits and GIT mode
2 participants