Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code refactoring v2 #4572

Merged
merged 16 commits into from
Jan 22, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jan 20, 2024

Description

Code Refactoring and Restructuring for App Store Deployment services
Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


nishant-d and others added 10 commits January 17, 2024 14:06
* retry envs added

* json naming

* migration for image scan plugin and retry env fix

* fix

* image scan migration script updated - added new input variables

* migration updated

* migration updated

* name changed

* refactor

* added default value and change script no
* added sql-validator in git-hub action

* removed exit commands

* edited the grep with whole word

* modified

* modified comments

---------

Co-authored-by: Badal Kumar Prusty <[email protected]>
* Adds copacetic plugin

* copacetic plugin: adds plugin icon and updates url in migration file

* Update 211_copacetic_plugin_v1_0_0.up.sql

adds copa patch command exit condition

* Update 211_copacetic_plugin_v1_0_0.up.sql

adds exit 1 if patching multi architecture image

* dummy commit 211_copacetic_plugin_v1_0_0.up.sql

dummy commit

* chore: added sql-validator in git-hub action (#4255)

* added sql-validator in git-hub action

* removed exit commands

* edited the grep with whole word

* modified

* modified comments

---------

Co-authored-by: Badal Kumar Prusty <[email protected]>

* updates migration no.

---------

Co-authored-by: Badal Kumar <[email protected]>
Co-authored-by: Badal Kumar Prusty <[email protected]>
* Plugins icon

* eks and dockerslim plugin sql up

* eks and dockerslim plugin down script

* dockerslim plugin after review PR

* Changes after review dockerslim

* image changes

* new image dockerslim

* eks creation plugin

* Final PR commit, eks and dockerslim plugins
* update common-lib

* added idempotency code and common-lib version bump

* added the optionsal validations pubsub msg pre-processing-hooks logic and added duplicate trigger check as a validation for pre,post,deploy trigger flows

* bump common-lib

* added callback logger func

* sql scripts added

* query fix

* query fix

* fix

* refactoring

* remove dag exececutor dependency from ciEeventHalndler Sevice

* bump common-lib

* move context to trigger context

* add logs

* migration version fix

* remove test data

* update script number

---------

Co-authored-by: Kripansh <[email protected]>
* initial commit

* removed from hyperion

* changes

* added trace

* pr comments

* pg timeouts

* panic message constant

* cleaning up

* common lib version

* argo assets revert

* adding image scanner proxy route

* common-lib-update
@Ash-exp Ash-exp added the enhancement New feature or request label Jan 20, 2024
@Ash-exp Ash-exp self-assigned this Jan 20, 2024
Copy link

gitguardian bot commented Jan 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Ash-exp Ash-exp changed the base branch from chore-refactoring-v1 to chore-app-store-deployment-refactoring January 20, 2024 21:24
prakash100198 and others added 6 commits January 21, 2024 13:49
…es present in generic_note (#4568)

* script for initializing null identifier type col to 0(cluster type)

* script fix

* empty script for 216

* 216 up script revert
* FetchChartNotes return 4xx when installed app or installed app versions not found

* GetDeploymentHistory and GetInstalledAppVersion to return 4xx when installed app or installed app versions not found

* fixes

* adding pg:",discard_unknown_columns" in tables where doesn't exist

* fix for Git Sensor response

* fix for inception

* fix for k8s resource delete

* fix for pipeline already exists

* fix for pipeline already exists

* fix

* fix

* fix

* fix

* go mod version changes

* merged

* common lib main version sync

* main merge

---------

Co-authored-by: ShashwatDadhich <[email protected]>
* added cloud provider event

* added logger for testing

* logger removed

* common-lib version upgraded
@Ash-exp Ash-exp merged commit 9549cc2 into chore-app-store-deployment-refactoring Jan 22, 2024
2 checks passed
@Ash-exp Ash-exp deleted the chore-refactoring-v2n branch January 22, 2024 12:35
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

119 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants