Fix 'npm run lint' #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasperzgonec
commented
Aug 11, 2025
gasperzgonec
commented
Aug 11, 2025
patricijabrecko
requested changes
Aug 22, 2025
There was a problem hiding this comment.
Overall, I think this is a good direction to go into. I have some questions and added some suggestions.
Other than that, please remove all changes from the test folder. We should not change it because a different team is responsible for maintaining it. If you have any specific questions about it, you can ask @navneel99
gasperzgonec
force-pushed
the
gasperz/ISS-185661
branch
from
6d3020c to
2e10e73
Compare
…ckage dependencies in package.json and package-lock.json.
…nd added unused variable handling in createTodo and updateTodo functions.
gasperzgonec
force-pushed
the
gasperz/ISS-185661
branch
from
68aef5b to
ed4eeee
Compare
patricijabrecko
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Approved from my side but let's also wait for a review from @radovanjorgic (and don't forget to test the import with these new changes)
radovanjorgic
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the 'npm run lint' command, which runs
eslint .in the background. I've added eslint configuration and fixed all warnings that persisted.DevRev issue
#ISS-185661
Documentation PR
no-docs