Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup and test emp::Fraction #498

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fixup and test emp::Fraction #498

merged 1 commit into from
Dec 12, 2023

Conversation

mmore500
Copy link
Member

@mmore500 mmore500 commented Dec 8, 2023

Closes #494

@mmore500 mmore500 closed this Dec 8, 2023
@mmore500 mmore500 deleted the test-fraction branch December 8, 2023 20:43
@mmore500 mmore500 restored the test-fraction branch December 8, 2023 20:44
@mmore500 mmore500 reopened this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37a7263) 77.53% compared to head (64460d9) 77.56%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   77.53%   77.56%   +0.03%     
==========================================
  Files         332      334       +2     
  Lines       39575    39631      +56     
==========================================
+ Hits        30684    30740      +56     
  Misses       8891     8891              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mercere99 mercere99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests are helpful; move to std::gcd is definite improvement.

Fraction class is still very much alpha, but that's fine since it's accurately labeled.

@mmore500 mmore500 merged commit 27f70f0 into master Dec 12, 2023
14 of 15 checks passed
@mmore500 mmore500 deleted the test-fraction branch December 12, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

math/Fraction.hpp is completely untested
2 participants