Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic client support and some utilities #93

Merged

Conversation

mertkayhan
Copy link
Contributor

@mertkayhan mertkayhan commented Aug 2, 2021

<Remember to add meaningful title>

<Short description of the PR>

I have been working with KubeLibrary in Openshift for a while now. I implemented some new features/utilities which made my life easier in my project. Hereby, I would like to add them to the KubeLibrary since they may help the community too.

Fixes #<issue number>

Before merge following needs to be applied:

  • At least one example testcase added in testcases/
  • Library Documentation regenerated according to Generate docs
  • PR entry added in CHANGELOG.md in In progress section
  • All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
  • Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI
fail_under = 67

@m-wcislo
Copy link
Collaborator

I need to take a closer look, but meanwhile would it be possible to add some examples for create, patch, .. or any of them, that would be very useful.

@mertkayhan
Copy link
Contributor Author

Hello @m-wcislo, I have added some examples under testcases/dynamic_client

Copy link
Collaborator

@m-wcislo m-wcislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This looks really nice, especially things like:

${conf}=     read conf     testcases/dynamic_client/resources/pod.yaml
create pod     ${conf}

I've added couple comments. Also please go through the checklist from the PR description before it is ready to merge.

setup.py Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
testcases/dynamic_client/dynamic_client.robot Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
testcases/dynamic_client/dynamic_client.robot Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
test/test_KubeLibrary.py Show resolved Hide resolved
test/test_KubeLibrary.py Show resolved Hide resolved
src/KubeLibrary/KubeLibrary.py Outdated Show resolved Hide resolved
test/test_KubeLibrary.py Show resolved Hide resolved
Copy link
Owner

@devopsspiral devopsspiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it looks good. The missing thing is that wait_pod_completion is somehow still there and please complete the checklist in PR description, like coverage threshold increase, generate docs etc.

Copy link
Collaborator

@m-wcislo m-wcislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Could you only bump the .coveragerc to 84. Don't want to these coverage efforts to be lost by someone else.

@m-wcislo m-wcislo merged commit 73a233d into devopsspiral:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants