Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precommit #469

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Update precommit #469

merged 4 commits into from
Jan 16, 2025

Conversation

beliaev-maksim
Copy link
Member

No description provided.

@allburov allburov merged commit ffbda40 into master Jan 16, 2025
5 checks passed
hooks:
- id: blacken-docs
additional_dependencies: [black]
- repo: https://github.com/asottile/reorder-python-imports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, why removing this one? I'm adding it back, that one is good one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry, now I see isort below. It has a different logic tho, I'll check it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use isort for 3 years now

As you can see it didn't change imports in our files and it is guaranteed by a wider community instead of a single engineer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds right, we'll keep it 👍

@beliaev-maksim beliaev-maksim deleted the update-precommit branch January 16, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants