Update README.md examples #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way they define the correct action And update upload-artifact path so that it can work as expected
|
@rajbos you are welcome, very happy to contribute even if it's a very small piece 👍 However, just one point: The CI seems to be stuck somewhere, preventing the merge may I ask you to have a look? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here are a few improvements for the examples defined in README.md
What are the incoming changes?
devops-actions/github-action-load-used-actions->devops-actions/load-used-actionspathproperty of actions/upload-artifact -> use${{ steps.load-actions.outputs.actions-file }}Why are they needed
#107
That way it works as expected 👍
How has this been achieved?
I used the action and figured out that this was the way to use it.